client: given both retries and errors, prefer retries #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 this makes sense |
Now that some errors (e.g. UnknownTopicOrParition) set *both* a retry flag and an error, we should handle retries first. This is sort-of non-idiomatic in that `updateMetadata` now returns a non-nil error with a "valid" result, but I think that's OK.
eapache
force-pushed
the
retry-over-error
branch
from
64a27f0 to
45741c4
Compare
wvanbergen
force-pushed
the
retry-over-error
branch
from
750b227 to
6f6b8e7
Compare
|
|
||
| metadataResponse3 := new(MetadataResponse) | ||
| metadataResponse3.AddTopic("new_topic", ErrUnknownTopicOrPartition) | ||
| seedBroker.Returns(metadataResponse3) |
There was a problem hiding this comment.
you can just re-use metadataResponse2 here, there's no need to construct a new one that's exactly the same
|
Good tests. (It would be nice to also have tests that the retry behaviour is sane - somehow I missed writing any of those the first time around - but one thing at a time). |
eapache
force-pushed
the
retry-over-error
branch
from
6f6b8e7 to
e41ef46
Compare
We permit it everywhere else we have backoffs. Use it to test the client's retry strategy.
eapache
added a commit
that referenced
this pull request
Mar 20, 2015
client: given both retries and errors, prefer retries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that some errors (e.g. UnknownTopicOrParition) set both a retry flag and
an error, we should handle retries first. This is sort-of non-idiomatic in that
updateMetadatanow returns a non-nil error with a "valid" result, but I thinkthat's OK.
@Shopify/kafka follow-up to #372